ReferenceIndexManager refactoring

jsusen · October 24, 2022, 9:07am

While working on Architect - Screen / screen section references not found for UI action - #4 by jsusen I decided to refactor the ReferenceIndexManager.

I think the code is a bit more readable now. The references are available a little faster too. The core works according to my checks. @washi could you check that it actually works? Thanks.

Note:
The pull request also contains the fix to Architect - Screen / screen section references not found for UI action - #4 by jsusen

tvavrda · November 6, 2022, 9:36pm

Getting the references is implemented wrong. Dependencies are to be returned by each model element by overriding GetExtraDependencies method.

See an example here:

github.com

origam/origam/blob/0ddd607b8885730f07c9727a4bfeb861011eff02/backend/Origam.Schema.LookupModel/SchemaItems/DataLookupMenuBinding.cs#L59


      
          		public DataLookupMenuBinding(Key primaryKey) : base(primaryKey)	{}
          
          
		#region Overriden AbstractSchemaItem Members
          		public override string ItemType
          		{
          			get
          			{
          				return CategoryConst;
          			}
          		}
          		public override void GetExtraDependencies(System.Collections.ArrayList dependencies)
          		{
          			dependencies.Add(this.MenuItem);
          
          
			AbstractSchemaItem menu = this.MenuItem;
          			while(menu.ParentItem != null)
          			{
          				menu = menu.ParentItem;
          				dependencies.Add(menu);
          			}

jsusen · November 7, 2022, 10:22am

This is related to Architect - Screen / screen section references not found for UI action
not the refactoring

jsusen · November 15, 2022, 1:09pm