Screen (section) condition of a workflow UI action can only be selected as a submenu of an unmapped context store

zcapkova · May 5, 2021, 3:21pm

I have created a sequential workflow action for an entity and linked it to a workflow with more context stores. I have only mapped one of them. When I want to add a screen / screen section condition to the UI action, it can only be done via a submenu of the unused context store name.

tvavrda · May 5, 2021, 3:30pm

I would even say that anything else than Parameter Mapping should NOT appear as a possibility for mapping a parameter.

tvavrda · May 5, 2021, 4:14pm

The problem lies here:

github.com

origam/origam-source/blob/e2c1f3b5bdf02c62798daf044c56340f1363922f/Origam.Workbench/Commands/MenuItemBuilders.cs#L87


if (nonpersistentNode != null)
{
    activeItem = nonpersistentNode.ParentNode as AbstractSchemaItem;
}
Type[] validTypes = ValidTypes(factory);
var items = new List<AsMenuCommand>();
if (factory.NewItemTypes != null)
{
    ArrayList names = new ArrayList();
    // filter out only the names that do not exist already in the children collection
    foreach (string name in factory.NewTypeNames)
    {
        bool found = false;
        foreach (AbstractSchemaItem existing in activeItem.ChildItems)
        {
            if (existing.Name == name)
            {
                found = true;
                break;
            }
        }

NewTypeNames is not limited to any specific model element. This was not foreseen when we created the new Screen Condition and Screen Section Condition and nobody complained Client Script Invocation which is not used much.

We need to somehow mark those classes that can be named and those that shouldn’t.

Any class that overrides NewTypeNames has to be reviewed and the relevant child items must be marked if they do or don’t support name suggestions.

Example:

github.com

origam/origam-source/blob/e2c1f3b5bdf02c62798daf044c56340f1363922f/Origam.Schema.MenuModel/SchemaItems/EntityWorkflowAction.cs#L63


		}
	
		#region Overriden AbstractDataEntityColumn Members
		
		public override void GetExtraDependencies(System.Collections.ArrayList dependencies)
		{
			dependencies.Add(this.Workflow);
			base.GetExtraDependencies (dependencies);
		}


		public override IList<string> NewTypeNames
		{
			get
			{
				try
				{
					IBusinessServicesService agents = ServiceManager.Services.GetService(typeof(IBusinessServicesService)) as IBusinessServicesService;
					IServiceAgent agent = agents.GetAgent("WorkflowService", null, null);
					return agent.ExpectedParameterNames(this.Workflow as AbstractSchemaItem, "ExecuteWorkflow", "Parameters");
				}
				catch