Cannot build origam-sms

tvavrda · January 14, 2022, 9:44am

I was trying to build origam-sms using GitHub Actions and it is failing because of a bad icon resource.

origam/origam-sms/blob/80bd2b75bef9f86c948006bb39073f7cf873898b/Origam-sms/Origam-sms.csproj#L22

    
      
                  <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
                  <PackageLicenseExpression>GPL-3.0-only</PackageLicenseExpression>
                  <PackageIcon>OrigamIcon.png</PackageIcon>
                  <PackageIconUrl />
                  <PackageVersion>1.0.2</PackageVersion>
                  <PackageReleaseNotes>- Fixed description typo.
          - updated interface to void</PackageReleaseNotes>
              </PropertyGroup>
          
          
    <ItemGroup>
                <None Include="..\..\..\Downloads\OrigamIcon.png">
                  <Pack>True</Pack>
                  <PackagePath></PackagePath>
                </None>
              </ItemGroup>
          
          
</Project>

We should also move the package to origam NuGet repository.

github.com

origam/origam-sms/blob/80bd2b75bef9f86c948006bb39073f7cf873898b/Origam-sms/Origam-sms.csproj#L10

    
      
          <Project Sdk="Microsoft.NET.Sdk">
          
          
    <PropertyGroup>
                  <RootNamespace>Origam_sms</RootNamespace>
                  <TargetFrameworks>net461;netstandard2.0</TargetFrameworks>
                  <Title>Origam.Sms</Title>
                  <Authors>origam</Authors>
                  <Description>SMS interface for sending SMS.</Description>
                  <PackageProjectUrl>https://community.origam.com/</PackageProjectUrl>
                  <RepositoryUrl>https://github.com/MikulaJan/origam-sms</RepositoryUrl>
                  <PackageTags>origam</PackageTags>
                  <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
                  <PackageLicenseExpression>GPL-3.0-only</PackageLicenseExpression>
                  <PackageIcon>OrigamIcon.png</PackageIcon>
                  <PackageIconUrl />
                  <PackageVersion>1.0.2</PackageVersion>
                  <PackageReleaseNotes>- Fixed description typo.
          - updated interface to void</PackageReleaseNotes>
              </PropertyGroup>

And I think TargetFrameworks could be solely netstandard2.0.

jsusen · January 25, 2022, 4:22pm