Changing parent in a detail record causes an error in a lazily loaded screen

urbanekv · July 17, 2023, 2:35pm

I was trying to change parent in a detail (child) row in a master-detail screen. The parent could be changed by a dropdown field in the child row.

I was expecting the child row to be changed and then it disappeared after saving the form.

Instead I’ve got the following error: Server error occurred. Please check server log for more details:
ForeignKeyConstraint FK_LogisticsRouteSchedule requires the child key values (xxxxx) to exist in the parent table.

urbanekv · July 17, 2023, 3:24pm

how to replicate:

checkout repository with a new version of demo model, the following branch
GitHub - origam/origam at changing-parent-2022-4
go to Menu > Widgets > Sections > Master Detail with a parent column
it’s necessary to have at least 2 master records and at least one child record in the first parent
go to the first master record and edit the child record’s parent column so that it point into the second master record. You get the error.

jsusen · July 19, 2023, 7:34am

Fix to this problem is some what complicated. The exception is thrown here:

github.com

origam/origam/blob/37f48ae1f8246bf93fecd85ffb7da7295e66a214/backend/Origam.Server/Session Stores/SessionStore.cs#L1747C1-L1747C1


      
          row[property] = newValue;

The problem is that the row’s dataset only contains the original parent row but not the new one.

Solution one:
add row.Table.DataSet.EnforceConstraints = false; before the line 1747 does fix the problem but it does not look like something we want to do.

Solution two:
load the missing row into the dataset. This would contradict the idea behind the lazy loaded screen. So probably not a good idea either.

This issue will be on hold until we can consult @tvavrda.

urbanekv · July 19, 2023, 9:01am

From my point of view, I don’t see any problem to load the other master record, since it’s needed. It’s the point of lazy-loading - load it when it’s needed, isn’t it?. So I would go with solution 2.

washi · July 19, 2023, 9:45am

The current implementation works with only one master record in memory.

github.com

origam/origam/blob/37f48ae1f8246bf93fecd85ffb7da7295e66a214/backend/Origam.Server/Session Stores/FormSessionStore.cs#L359


      
          // for new rows we don't even try to load the data from the database
          if (row == null || row.RowState != DataRowState.Added)
          {
              if (!ignoreDirtyState && this.Data.HasChanges())
              {
                  throw new Exception(Resources.ErrorDataNotSavedWhileChangingRow);
              }
          
          
    this.CurrentRecordId = null;
          
          
    SetDataSource(LoadDataPiece(id));
          }
          
          
this.CurrentRecordId = id;
          
          
DataRow actualDataRow = GetSessionRow(entity, id);
          UpdateListRow(actualDataRow);
          
          
ChangeInfo ci = GetChangeInfo(null, actualDataRow, 0);
          result.Add(ci);

Implementing support for loading second master record doesn’t seem to be a matter of simple adjustment of the current code and could have an impact on other things.

tvavrda · October 20, 2023, 3:05pm

This would be too much for such a specific use case. I would solve it by an action button that would offer a dialog for choosing another parent record and then load/update/save workflow to save it directly in the db. Then set the action button to RefreshAfterReturn: ReloadActualRecord so the updated record would disappear from the current screen.