Color grid editor - it is not possible to enter value into hex field or RGB fields

washi · December 28, 2022, 5:29pm

It is not possible to edit color value in color grid editor via hex field or RGB fields. Editor works in the form view.

See in Menu/Settings/General/System colors.

jsusen · June 23, 2023, 3:35pm

github.com/origam/origam

FIX: Color picker rendering flaw

origam:master ← origam:fix-color-picker-rendering

opened 10:12AM - 20 Jun 23 UTC

ptomask

+49 -56

This was reported as the ColorPicker was unable to be edited by any input fields… in grid view but works correctly in form view. Further investigations revealed that the field is actually broken in both grid and form views and the main issue is an infinite loop of ColorPicker wasted renders. The exact mechanism of why that only caused the editing issue in grid views and not form views remains unknown, expectation is rather being not properly editable in both, I suspect the difference in details of how the focusing works in grid and form views, which caused any internal color picker input field getting the focus stolen each render in grid view and not in form view. The infinite loop was present because of an unstable function reference passed to div element. Rough loop description follows: 1. The div element receives new ref reference 2. So the reference gets called. 3. Dropdown's Measure component measured child ref gets called by reference function from previous point. 4. Measure component rerenders its measured content, because its dimensions might have changed. 5. The content contains the div mentioned in pt. 1 closing the loop. Conclusion points: 1. We shall investigate React rendering performance from time to time. Here "Highlight updates" from React DevTools helped a lot. 2. We shall think twice before directly passing an arrow function to a component prop. 3. Maybe this would not happen if the Measure component is little bit more well-behaved, but here the "think twice about unstable references" point is of much stronger importance, I would not blame the Measure component.

washi · July 5, 2023, 10:52am

This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.