DefaultSet is being cached

gmcr.cz · October 12, 2022, 7:51am

I think that DefaultSet is cached. When I use the same DataStructure with two different DefaultSets that are used on two different screens in menu then when I open screen A with default value of column A set to X everything works just fine. But when I open second screen B with default value of column A set to Y (column is obviously the same, lets say refAId) then instead of new value Y there is value X being saved.

It is being cashed. The only solution is to logout and open first the screen I want to work with.

My version is 2021.1.0.2451. I checked it also on 2022.1.x and the bahaviour was the same.

tvavrda · October 12, 2022, 8:12am

That is quite strange, a default set is a part of the cache key so it should work.

github.com

origam/origam/blob/f62f9250a7904eeb61fb5bb95856ede61d724939/backend/Origam.DA.Service/Generators/DatasetGenerator.cs#L286


      
          		{
          			return CreateDataSet(ds, includeCalculatedColumns, defaultSet, culture, false);
          		}
          
          
		private DataSet CreateDataSet(DataStructure ds, bool includeCalculatedColumns,
          			DataStructureDefaultSet defaultSet, CultureInfo culture, bool forceBuildFromDatastructure)
          		{
          			if(ds == null) throw new ArgumentNullException("ds", ResourceUtils.GetString("ErrorDatastructureNull"));
          
          
			Hashtable dsCache = GetCache();
          			string cacheKey = ds.Id.ToString() + (defaultSet == null ? Guid.Empty.ToString() : defaultSet.Id.ToString());
          			// get strongly typed dataset class
          			if (ds.DataSetClass != null && ds.DataSetClass.Trim() != "" && !forceBuildFromDatastructure)
          			{
          				// get DS from strongly typed dataset class
          				string[] splittedDataSetClass = ds.DataSetClass.Split(',');
                          if(splittedDataSetClass.Length < 2)
                          {
                              throw new ArgumentException(
                                  ResourceUtils.GetString("ErrorDataSetClassInvalid"), 
                                  "DataSetClass");

It would be great to have a test case for this in our end to end testing model. @washi would it be a good idea if @gmcr.cz would add an example for it? And if so, could you maybe document the way how to do so?

washi · October 12, 2022, 1:55pm

I don’t know. As for the test documentation I think @jsusen is better candidate to write it.

gmcr.cz · October 13, 2022, 9:21am

Thank you for your answers. I tested futher more and found out that when I have template assigned to screen in menu and also use defaultset at the same time, the defaultset value is not applied and instead the field get default value from entity/datascructure which is wrong.

E.g. I have template to generate some values using lookups etc. But I do not generate field refSomeStateId. When I clik Add button on screen, I would like Default set to fill in refSomeStateId default value according to from what form I add the record. A from screen A, B from screen B. When using template and default set asside this does not happen.

tvavrda · October 15, 2022, 9:21am

Just to confirm: You use a template-set and a default-set at the same time and the default-set is then ignored?

gmcr.cz · October 15, 2022, 10:22am

Yes. Exactly like you say.