Dubious Cast

washi · May 20, 2025, 5:16pm

backend/Origam.Workflow/Service Agents/ModelServiceAgent.cs when processing request TraceObject uses dubious cast from ITraceable to IPersistent:

github.com/origam/origam

backend/Origam.Workflow/Service%20Agents/ModelServiceAgent.cs

a3d5333f7


      
                          .RetrieveInstance<ITraceable>(
                              objectId, 
                              useCache: true);
                      string traceType = Parameters.Get<string>("TraceType");
                      if (!Enum.TryParse(traceType, out Trace trace))
                      {
                          throw new ArgumentException($"\"{traceType}\" cannot be parsed to {nameof(Trace)}");
                      }
                      traceable.TraceLevel = trace;
                      persistenceService.SchemaProvider.Persist(
                          traceable as IPersistent);
                      result = traceable.TraceLevel;
                      break;
                  }
                  default:
                      throw new ArgumentOutOfRangeException(nameof(MethodName),
                          MethodName, ResourceUtils.GetString("InvalidMethodName"));
              }
          }
          #endregion
          #region Private Methods

There is no class implementing both interfaces, so the Persist operation fails.

The code should be reviewed and improved.