Upgrade everything to XsltCompiledTransform

tvavrda · February 12, 2025, 6:09pm

It is not completely clear where are we using OldXsltEngine. It seems to be used by rule processing in Architect, making it hard to debug some problems because of a difference in behavior between the Architect and the Server. It should not be used for anything these days.

This class should be removed from the source code, including XsltEngineType.XslTransform enum.

github.com/origam/origam

backend/Origam.Rule/Xslt/OldXsltEngine.cs

99c915851


      
          using System.Collections.Generic;
          using System.IO;
          using System.Xml;
          using System.Xml.XPath;
          using System.Xml.Xsl;
          using Origam.DA.ObjectPersistence;
          using Origam.Rule.XsltFunctions;
          using Origam.Service.Core;
          
          namespace Origam.Rule.Xslt;
          class OldXsltEngine : MicrosoftXsltEngine
          {
          #region Constructors
              public OldXsltEngine()
              {
              }
          public OldXsltEngine(IEnumerable<XsltFunctionsDefinition> xsltFunctionDefinitions) : 
                  base (xsltFunctionDefinitions)
          	{
          	}
              public OldXsltEngine(IPersistenceProvider persistence=null) : base (persistence)

It is possible that metamodel has to be upgraded as transformations/rules might still be using XslTransform parameter.

washi · February 24, 2025, 8:35am

Please review also why mvp.xml is still in the final build and remove the reason for it.

jsusen · February 27, 2025, 11:26am