Workflow - finish transition to single-threaded handling

jsusen · May 4, 2021, 10:20am

Threads are still used in WorkflowHost class.

origam/origam-source/blob/5d445ec0d08aac46a4361e4f6bb3b345e13dc3bb/Origam.Workflow/WorkflowHost.cs#L169


        {
            Tasks.UIEngineTask task = (Tasks.UIEngineTask)_runningForms[taskId];


            if (task == null)
            {
                throw new ArgumentOutOfRangeException(ResourceUtils.GetString("ErrorTaskNotRunning", taskId.ToString()));
            }


            _runningForms.Remove(taskId);


            Thread thread = new Thread(new ThreadStart(task.Abort));
            PrepareAndStartThread(thread, task);
        }


        public void FinishWorkflowForm(Guid taskId, IDataDocument data)
		{
			Tasks.UIEngineTask task = (Tasks.UIEngineTask)_runningForms[taskId];


			if (task == null)
			{
				throw new ArgumentOutOfRangeException(ResourceUtils.GetString("ErrorTaskNotRunning", taskId.ToString()));

github.com

origam/origam-source/blob/5d445ec0d08aac46a4361e4f6bb3b345e13dc3bb/Origam.Workflow/WorkflowHost.cs#L186




			if (task == null)
			{
				throw new ArgumentOutOfRangeException(ResourceUtils.GetString("ErrorTaskNotRunning", taskId.ToString()));
			}


			_runningForms.Remove(taskId);
            
			task.Result = data;


            Thread thread = new Thread(new ThreadStart(task.Finish));
            PrepareAndStartThread(thread, task);
		}


        private static void PrepareAndStartThread(Thread thread, Tasks.UIEngineTask task)
        {            
            thread.Name = "Workflow " + task.Engine.WorkflowInstanceId.ToString();
            thread.IsBackground = true;
            thread.CurrentCulture = System.Threading.Thread.CurrentThread.CurrentCulture;
            thread.CurrentUICulture = System.Threading.Thread.CurrentThread.CurrentUICulture;
            thread.Start();